Difference between revisions of "Talk:E-book comb.as"

From Organic Design wiki
m
(going well, but read this stuff carefully)
Line 6: Line 6:
 
::I'll wait until you've cleaned it up and reduced to single function using tx,ty before looking at that lot I think --[[User:Nad|Nad]] 09:05, 21 Dec 2006 (NZST)
 
::I'll wait until you've cleaned it up and reduced to single function using tx,ty before looking at that lot I think --[[User:Nad|Nad]] 09:05, 21 Dec 2006 (NZST)
 
:::Some problem with iterating with Ming I think, works fine otherwise.  [[User:Jack|Jack]] 00:14, 22 Dec 2006 (NZST)
 
:::Some problem with iterating with Ming I think, works fine otherwise.  [[User:Jack|Jack]] 00:14, 22 Dec 2006 (NZST)
 +
::::It's going well, but here's a list of issues to sort out...
 +
::::*you haven't reduced down from the diffs as explained above, you've still got duplicated code which is pointless since the only difference between all 6 contingencies is sign-changes. Just read the notes aboce carefully, don't just skim over them.
 +
::::*you've got big problems with your logic which will be why its not iterating properly. Don't do any trial-and-error, make notes don't try and do it in your head. Think about what the roles of .across, .down, j and k actually are. --[[User:Nad|Nad]] 00:26, 22 Dec 2006 (NZST)

Revision as of 00:26, 22 December 2006

Those diffs are pretty revealing ay? ;-)

Notice that the differences can all be expressed as simple changes of sign of an item in some of the expressions. Tx is -1 or +1, Ty is -1, 0 or +1. Tx and Ty use those values so that they can be used as multipliers to either change the sign of what they multiplied with (if its -1) or leave it unchanged if its +1.

Yep thats helpful, ta. I've passed the variables into the function now so I'm happy Jack 23:40, 20 Dec 2006 (NZST)
I'll wait until you've cleaned it up and reduced to single function using tx,ty before looking at that lot I think --Nad 09:05, 21 Dec 2006 (NZST)
Some problem with iterating with Ming I think, works fine otherwise. Jack 00:14, 22 Dec 2006 (NZST)
It's going well, but here's a list of issues to sort out...
  • you haven't reduced down from the diffs as explained above, you've still got duplicated code which is pointless since the only difference between all 6 contingencies is sign-changes. Just read the notes aboce carefully, don't just skim over them.
  • you've got big problems with your logic which will be why its not iterating properly. Don't do any trial-and-error, make notes don't try and do it in your head. Think about what the roles of .across, .down, j and k actually are. --Nad 00:26, 22 Dec 2006 (NZST)